LibWeb: Fix NodeIterator retargeting during removals #10404
Merged
shannonbooth merged 2 commits intoJul 3, 2026
Merged
Conversation
Align NodeIterator with the current DOM spec traversal and pre-removal algorithms. The spec now covers the cases we were previously working around to match the behaviour of other engines. The algorithm we had implemented to protect against removal during filtering matches the spec algorithm quite closely, with slightly different factoring. See: * whatwg/dom#1479 * whatwg/dom#1477 This fixes the case where removing an ancestor of the reference or candidate reference, with the pointer before it and no following node inside the root, should retarget to the previous in-tree node instead of leaving the iterator on a detached node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align NodeIterator with the current DOM spec traversal and pre-removal
algorithms. The spec now covers the cases we were previously working
around to match the behaviour of other engines. The algorithm we had
implemented to protect against removal during filtering matches
the spec algorithm quite closely, with slightly different factoring.
See:
This fixes the case where removing an ancestor of the reference or
candidate reference, with the pointer before it and no following
node inside the root, should retarget to the previous in-tree node
instead of leaving the iterator on a detached node.